fix: content edit #664
fix: content edit #664
Conversation
Thank you for the review 🙏 |
| {...register("name", { | ||
| required: t("message.name_is_required"), | ||
| })} |
There was a problem hiding this comment.
Hi @IkbelTalebHssan, i have noticed that the input helperText attribute is accidentally removed
| {...register("name", { | |
| required: t("message.name_is_required"), | |
| })} | |
| {...register("name", { | |
| required: t("message.name_is_required"), | |
| })} | |
| helperText={errors.name ? errors.name.message : null} |
There was a problem hiding this comment.
accidentally removed
Thank you @yassinedorbozgithub for the review 🙏
Fixed ✔️
| useEffect(() => { | ||
| if (open) reset(); | ||
| }, [open, reset]); | ||
|
|
||
| useEffect(() => { | ||
| if (data) { | ||
| reset({ | ||
| name: data.name, | ||
| }); | ||
| } else { | ||
| reset(); | ||
| } | ||
| }, [data, reset]); |
There was a problem hiding this comment.
As a general rule, useEffect() should be place at the end, before the "return"
There was a problem hiding this comment.
As a general rule, useEffect() should be place at the end, before the "return"
Updated to be at the end ✔️
| } else { | ||
| createContentType(params); | ||
| createContentType({ ...params, name: params.name || "" }); |
There was a problem hiding this comment.
| createContentType({ ...params, name: params.name || "" }); | |
| createContentType({ ...params, name: params.name || "" }); |
The content type "name" attribute should not be empty. In which case are getting it empty?
There was a problem hiding this comment.
Correct fixed that ✔️
Motivation
We need to ensure that content["dynamicFields"] is defined before trying to access its properties.
Fixes (issue)
Type of change:
Please delete options that are not relevant.
Checklist: